Fix minimum version bound for ModelingToolkit#132
Merged
ChrisRackauckas merged 1 commit intoDec 30, 2025
Merged
Conversation
The minimum version for ModelingToolkit was set to 10.0.0, but this package requires at least 10.10.0. In earlier v10.x versions, ODESystem was either not exported (v10.0.0-10.2.x) or was a function alias rather than a proper Type (v10.3.0-10.9.x), which breaks the type annotations used in this package (e.g., `sys::ODESystem`). The issue was discovered by testing the package with minimum versions of dependencies: - v10.0.0-10.2.x: ODESystem not exported at all - v10.3.0-10.9.x: ODESystem exported as a function, not a Type, causing "invalid type for argument sys" errors - v10.10.0+: ODESystem is a proper Type (IntermediateDeprecationSystem) that can be used as a type annotation Verified that all tests pass with ModelingToolkit v10.10.0. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
10to10.10Problem
The package was specifying
ModelingToolkit = "10"as the minimum version, but the code fails to load with ModelingToolkit versions prior to v10.10.0 due to changes in howODESystemis exported:ODESystemis not exported at allODESystemis exported as a function/alias, not a proper TypeODESystemis a proper Type (IntermediateDeprecationSystem) that can be used in type annotationsThe package uses
ODESystemas a type annotation in function signatures (e.g.,function get_deqs(sys::ODESystem)), which requiresODESystemto be a valid Type.Changes
Project.tomlto requireModelingToolkit = "10.10"test/Project.tomlto requireModelingToolkit = "10.10"Test plan
ODESystem not defined)invalid type for argument sys)CC: @ChrisRackauckas
🤖 Generated with Claude Code